gc-font-tool: use original glyph widths #8874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Font files regenerated without dithering from Droid Sans Fallback.
|
Could you post a screenshot of what this looks like in-game? |
|
It's still not pretty. old: new: IPL ROM: |
iwubcode
reviewed
Aug 8, 2020
| static_assert(std::size(windows_1252_font_table) == 224); | ||
|
|
||
| // List of horizontal glyph widths | ||
| const uint8_t windows_1252_widths_table[] = |
There was a problem hiding this comment.
Just curious, how did you get these arrays?
Should you use a std::array instead?
There was a problem hiding this comment.
It's not clear to me whether something as trivial as glyph widths falls under copyright, but I'd rather be safe than sorry, so I've closed this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves alignment issues with multiple GameCube games that print things like "Press (A) to continue" where "(A)" is a separately rendered button texture.
Font files regenerated from Droid Sans Fallback (without dithering).