Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Use octagonal stick gate in overlay #8907

Merged
merged 2 commits into from Jul 8, 2020
Merged

Android: Use octagonal stick gate in overlay #8907

merged 2 commits into from Jul 8, 2020

Conversation

JosJuice
Copy link
Member

Currently, the touch controller overlay uses a square gate for sticks. The first commit of this PR changes that so that it instead uses the stick gate configured in the INI, which ensures that the values sent to the core are appropriately scaled regardless of what is configured in the INI and makes the overlay look nicer if the INI is set to a stick gate that matches the graphics.

With that change out of the way, we can essentially revert PR #8503, fixing the current problems with being unable to run sideways when using certain gamepads in certain games, while not breaking the touch controls bug https://bugs.dolphin-emu.org/issues/11911 which was fixed by PR #8503.

@JosJuice
Android: Enfore correct stick gate in overlay
db75509 
Currently, the touch controller overlay uses a square gate for
sticks. This commit changes that so that it instead uses the
stick gate configured in the INI, which ensures that the values
sent to the core are appropriately scaled regardless of what
is configured in the INI and makes the overlay look nicer
if the INI is set to a stick gate that matches the graphics.
@JosJuice
Android: Don't use square stick calibration
f8e0ece 
This essentially reverts d9c78d5. Thanks to the previous commit,
the touch controls issue which was fixed by d9c78d5 is still fixed.
The behavior for gamepads is reverted, bringing back the ability
to run diagonally in games that had trouble with it after d9c78d5.
@jordan-woyak
Copy link
Member

Won't removing the default calibration reintroduce "thumbstick down acts like up" issue for gamepads (not touchscreen)?

@JosJuice
Copy link
Member Author

JosJuice commented Jul 2, 2020

It would, if the range of the gamepad stick is very large. I'm not sure if that is something that is common in practice. Of course, the proper fix for that problem is to make it configurable, which is easier said than done with the current state of the Android input code...

@lioncash lioncash merged commit 8728718 into dolphin-emu:master Jul 8, 2020
@JosJuice JosJuice deleted the android-overlay-stick-gate branch July 8, 2020 12:56
@BreakPoints
Copy link

It would, if the range of the gamepad stick is very large. I'm not sure if that is something that is common in practice. Of course, the proper fix for that problem is to make it configurable, which is easier said than done with the current state of the Android input code...

I can confirm that this reverts the fix for my cheap iPega PG-9025 Bluetooth controller. Down is now up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@JosJuice @jordan-woyak @BreakPoints @lioncash