DolphinQt: Expose SYSCONF sound setting #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
reviewed
Jul 2, 2020
| @@ -126,6 +130,12 @@ void WiiPane::CreateMisc() | |||
| m_system_language_choice->addItem(tr("Traditional Chinese")); | |||
| m_system_language_choice->addItem(tr("Korean")); | |||
|
|
|||
| m_sound_mode_choice_label = new QLabel(tr("Sound:")); | |||
| m_sound_mode_choice = new QComboBox(); | |||
There was a problem hiding this comment.
Might need a tooltip explaining that with HLE there is no difference between Stereo and Surround
There was a problem hiding this comment.
And also that this needs to be set to Surround to even enable DPLII in the Audio panel
There was a problem hiding this comment.
Shouldn't that rather be explained where the DSP HLE and DPLII decoder settings are? This is not the only way to control whether games output surround sound, in particular not for GameCube games, for which this has no effect.
There was a problem hiding this comment.
You definitely know better than me. As long as it's somewhere, it's fine. There are a lot of settings in Dolphin and for a new user it isn't easy.
lioncash
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.