Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan build fixes #893

Merged
merged 2 commits into from
Sep 3, 2014
Merged

Scan build fixes #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e340b1
Initialize variables to silence garbage return warning from scan-build.
rohit-n Aug 28, 2014
4c14ebd
Remove pointless initializations.
rohit-n Aug 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions Source/Core/Common/x64Emitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ void OpArg::WriteSingleByteOp(XEmitter *emit, u8 op, X64Reg _operandReg, int bit
//operand can either be immediate or register
void OpArg::WriteNormalOp(XEmitter *emit, bool toRM, NormalOp op, const OpArg &operand, int bits) const
{
X64Reg _operandReg = (X64Reg)this->operandReg;
X64Reg _operandReg;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

if (IsImm())
{
_assert_msg_(DYNA_REC, 0, "WriteNormalOp - Imm argument, wrong order");
Expand All @@ -1045,7 +1045,6 @@ void OpArg::WriteNormalOp(XEmitter *emit, bool toRM, NormalOp op, const OpArg &o

if (operand.IsImm())
{
_operandReg = (X64Reg)0;
WriteRex(emit, bits, bits);

if (!toRM)
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/DiscIO/BannerLoaderWii.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace DiscIO

CBannerLoaderWii::CBannerLoaderWii(DiscIO::IVolume *pVolume)
{
u64 TitleID;
u64 TitleID = 0;
pVolume->GetTitleID((u8*)&TitleID);
TitleID = Common::swap64(TitleID);

Expand Down
2 changes: 1 addition & 1 deletion Source/Core/DiscIO/VolumeGC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ u64 CVolumeGC::GetRawSize() const

bool CVolumeGC::IsDiscTwo() const
{
bool discTwo;
bool discTwo = false;
Read(6,1, (u8*) &discTwo);
return discTwo;
}
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/DolphinWX/ISOFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ const std::string GameListItem::GetWiiFSPath() const

if (DiscIO::IsVolumeWiiDisc(iso) || DiscIO::IsVolumeWadFile(iso))
{
u64 title;
u64 title = 0;

iso->GetTitleID((u8*)&title);
title = Common::swap64(title);
Expand Down