InputCommon/GCAdapter: Fix offbrand "GCAdapters". #8933
Conversation
|
I can test GC adapter code on Android, but I don't have Nyko. |
|
This adapter here still doesn't work. https://cdn.discordapp.com/attachments/521710974827495435/729598461900488754/unknown.png It spams the logs with this: 17:55:603 InputCommon\GCAdapter.cpp:91 E[SI]: adapter libusb read failed: err=LIBUSB_ERROR_IO |
|
I have had two people test master and this PR with a pdobq adapter and this fix has worked for them. Image of the adapter for reference: https://cdn.discordapp.com/attachments/363806218181017601/729876869658181702/image0.jpg EDIT: Just had someone test with different adapter brand and it worked |
jordan-woyak
force-pushed
the
gcadapter-nyko
branch
from
788f424
to
f2fd5c7
Compare
|
@NikhilNarayana Thanks for having some testing done, even though you didn't have to! |
|
This is the root for my adapter not working I believe. Idk what went down but my adapter was working fine last night and after updating today it no longer works. |
|
Could you list what adapter you are using? |
|
This version of dolphin made my Mayflash Gamecube adapter stop working it keeps giving me the error "Error Opening Adapter: Pipe error" when you check "GameCube Adapter for Wii U"'s configure option. I tried the previous developmental build (version 5.0-12261) and it was working fine again, please fix this problem. |
|
Issue reports can be filed here: https://bugs.dolphin-emu.org/projects/emulator/issues |
|
thank you, it looks like someone already made a post about some adapters not working because of this build. |
This makes my Nyko-branded GCAdapter work and probably others. Please test.
Note that
libusb_control_transfercalls give aLIBUSB_ERROR_BUSYerror within a hotplug callback so I've introduced anEventto initialize adapters in the "scanning" thread.I'm not entirely happy with this fix but GCAdapter needs a complete rewrite. The error handling is bad. The inter-thread communication is bad. And 90% of the logic is copy-pasted to GCAdapter_Android.cpp.
This PR does not attempt to fix the Android-side of things. I can't test there.