Android: Increase targetSdkVersion to 29 #8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since updating to 28 took us so long that Google Play started requiring updates to target 28 before we actually merged the PR that made us target 28, I'm trying to get the update to 29 done early. Setting targetSdkVersion to 28 would normally force scoped storage on us, which we do not support yet. However, we can easily avoid this by setting android:requestLegacyExternalStorage="true". There will be no such luxury with targetSdkVersion 30, however...
degasus
approved these changes
Jul 14, 2020
lioncash
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since updating to 28 took us so long that Google Play started requiring updates to target 28 before we actually merged the PR that made us target 28, I'm trying to get the update to 29 done early.
Setting targetSdkVersion to 28 would normally force scoped storage on us, which we do not support yet. However, we can easily avoid this by setting android:requestLegacyExternalStorage="true". There will be no such luxury with targetSdkVersion 30, however...