DolphinQt/Debugger: Fix DBAT and IBAT registers in RegisterWidget #9121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the display of DBAT and IBAT registers past register 3 which is currently broken. Behavior can be verified by running some code to put a value in SPR 570 which will update DBAT5, however it won't update in the register window. Further, values displayed for IBATs after IBAT3 are actually DBAT values.
The issue is caused by the registers being added using the row index and incrementing all the way up to register 7 when the actual order of DBAT and IBAT registers have a gap between registers 3 and 4. (e.g
SPR_IBAT3Lis 535, butSPR_IBAT4Uis 560).