JIT: Fix caller-save registers on WIN64

[FioraAeterna]

No description provided.

[comex]

lgtm

[delroth]

+16 is just more magic. Could we instead split that into two separate enums, and maybe do the same with the registers?

Thanks.

[FioraAeterna]

I'm just sticking with how the current code works; refactoring it would be a much bigger patch, I think. There's already some (XMM0<<16) in other places in the code.

[delroth]

<< 16 or + 16?

:)

On Tue, Sep 2, 2014 at 11:13 AM, Fiora notifications@github.com wrote:

I'm just sticking with how the current code works; refactoring it would be
a much bigger patch, I think. There's already some (XMM0<<16) in other
places in the code.

—
Reply to this email directly or view it on GitHub
#923 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

[FioraAeterna]

Erm. +16. yes. xD

[lioncash]

At the very least I guess a comment can be made explaining the meaning behind + 16. Is that OK, @delroth?

[delroth]

I don't like it, but I guess it's fine for the time being...

On Tue, Sep 2, 2014 at 3:59 PM, Lioncash notifications@github.com wrote:

At the very least I guess a comment can be made explaining the meaning
behind + 16. Is that OK, @delroth https://github.com/delroth?

—
Reply to this email directly or view it on GitHub
#923 (comment).

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

[lioncash]

@delroth I do agree that an enum or variable constant should be used to represent it. However if it's interspersed like @FioraAeterna says, then I think it is out of scope for what this PR does.

[BhaaLseN]

Fine by me if we get a comment, and a follow-up PR :)