Take the size of the audio data into account when checking for the loop ... #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested MegaMan 9, Skies of Arcadia: Legends and some Resident Evil Games. And the MegaMan X Collection + Pacman World 2 videos. Everything checks out, and I can confirm Skies of Arcadia: Legends and the FMVs as being fixed. |
| @@ -111,6 +111,7 @@ u16 dsp_read_accelerator() | |||
| const u32 EndAddress = (g_dsp.ifx_regs[DSP_ACEAH] << 16) | g_dsp.ifx_regs[DSP_ACEAL]; | |||
| u32 Address = (g_dsp.ifx_regs[DSP_ACCAH] << 16) | g_dsp.ifx_regs[DSP_ACCAL]; | |||
| u16 val; | |||
| u8 step = 0; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…op address. Fixes the static audio in the FMV of Megaman X Collection, Pac Man World 2, off pitched instruments in Skies of Arcadia and audio desync in the Taiko no Tatsujin series. Fixes: issue 7154 issue 7222 issue 7280 issue 7457
|
@JMC47 could you post a build so i could do some testing too? Skidau seems not to be autotrusted for the buildbot to work. |
|
Wut :D I guess @skidau hasn't been doing a lot of Dolphin work recently. Fixing that. @dolphin-emu-bot rebuild |
lioncash
added a commit
that referenced
this pull request
Sep 1, 2014
Take the size of the audio data into account when checking for the loop address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...address. Fixes the static audio in the FMV of Megaman X Collection, Pac man World, off pitched instruments in Skies of Arcadia and audio desync in the Taiko no Tatsujin series.
Fixes:
issue 7154
issue 7222
issue 7280
issue 7457