GameSettings: Enable compatibility patches by default #9317
Conversation
|
I don't think it's fair to completely rule out some quality of life patches. I know it's a huge departure from your current criteria of only allowing patches that make games behave more like console, and there's a slippery slope argument, but if you look at it from a usability perspective, there's no reason not to have the save patches on for Pokemon unless they malfunction. How many android users are going to know it's there? Either way, for the current use? 100% approve. |
|
I'm not 100% opposed to extending the criteria, but if we're going to do that, I would like someone to open a separate PR for it so that it doesn't block the merge of this.
I do plan on adding cheats/patches to the Android GUI at some point :) |
If we want to enable codes in the default game INIs, we should have some way for users to disable them. This commit accomplishes that by adding a *_Disabled section corresponding to each *_Enabled section.
The previous commit adjusted the code for loading and this commit adjusts the code for saving.
This enables patches for game-breaking problems by default. My criterion for which patches to select was that the patch has to make the game's behavior closer to how the game acts on console. So workarounds for Dolphin not emulating caches accurately are enabled by default, but not things like Twilight Princess's minimap speedhack or patches for disabling memory card checks in Pokémon games.
JosJuice
force-pushed
the
default-enabled-codes
branch
from
6c0a4ec
to
36ecfdd
Compare
This pull request makes it possible for users to disable patches that are enabled by default, and enables patches for game-breaking problems by default.
My criterion for which patches to select was that the patch has to make the game's behavior closer to how the game acts on console. So workarounds for Dolphin not emulating caches accurately are enabled by default, but not things like Twilight Princess's minimap speedhack or patches for disabling memory card checks in Pokémon games.
This is a convenience which I think will be appreciated by people who want to play
Resident Evil 2 & 3Casper's Scare School: Spooky Sports Day.