Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: rewrite frame skipping code #957

Merged
merged 1 commit into from Sep 4, 2014

Conversation

degasus
Copy link
Member

@degasus degasus commented Sep 3, 2014

No description provided.

numVertices,
end - g_pVideoData,
g_bSkipCurrentFrame))
return 0;

This comment was marked as off-topic.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

lgtm

@skidau
Copy link
Contributor

skidau commented Sep 4, 2014

Interesting. In which cases can we see this code in action? Are movies that write directly to the XFB frameskipped?

@JMC47
Copy link
Contributor

JMC47 commented Sep 4, 2014

Frameskipping has not worked for me for a very long time; whenever I turn on frameskip, I lose all rendering whenever Dolphin slows down until I hit 60 again, which means it's not very useful for me. Unable to test, as such.

@degasus
Copy link
Member Author

degasus commented Sep 4, 2014

@skidau oh, I have only touched the way howto skip a frame, but I haven't touched the code which handles the logic which frame should be skipped. But it did work for me, so I thought it is already fine. Do you want me to also change this part or is this PR also fine without any UI changes?

@skidau
Copy link
Contributor

skidau commented Sep 4, 2014

@degasus, ok looks good to me

@skidau
Copy link
Contributor

skidau commented Sep 4, 2014

@degasus: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


@dolphin-emu-bot allowmerge

@TurboK234
Copy link
Contributor

Frame skipping has worked for me in some situations, as I'm heavily GPU restricted with Intel HD 4600 and i5 4670S, dropping fps to 30 while keeping the game speed normal whenever unable to maintain 60. Especially SMG1/SMG2 seemed to work ok this way.
But still I got some longer "freezes" when the frameskipping logic seemed to lag too much, which ended in sudden deaths ect, so I'm not using it anymore. Especially when Zelda ucode HLE fix made it possible to play without any FPS dips, basically.
This isn't in scope of this PR, but @skidau was wondering about frameskipping in general...

dolphin-emu-bot added a commit that referenced this pull request Sep 4, 2014
VideoCommon: rewrite frame skipping code
@dolphin-emu-bot dolphin-emu-bot merged commit 830a03c into dolphin-emu:master Sep 4, 2014
@degasus degasus deleted the frame_skipping branch February 3, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants