New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoCommon: rewrite frame skipping code #957
Conversation
numVertices, | ||
end - g_pVideoData, | ||
g_bSkipCurrentFrame)) | ||
return 0; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lgtm |
Interesting. In which cases can we see this code in action? Are movies that write directly to the XFB frameskipped? |
Frameskipping has not worked for me for a very long time; whenever I turn on frameskip, I lose all rendering whenever Dolphin slows down until I hit 60 again, which means it's not very useful for me. Unable to test, as such. |
@skidau oh, I have only touched the way howto skip a frame, but I haven't touched the code which handles the logic which frame should be skipped. But it did work for me, so I thought it is already fine. Do you want me to also change this part or is this PR also fine without any UI changes? |
@degasus, ok looks good to me |
@degasus: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. @dolphin-emu-bot allowmerge |
Frame skipping has worked for me in some situations, as I'm heavily GPU restricted with Intel HD 4600 and i5 4670S, dropping fps to 30 while keeping the game speed normal whenever unable to maintain 60. Especially SMG1/SMG2 seemed to work ok this way. |
2a858a5
to
8b84ddc
Compare
VideoCommon: rewrite frame skipping code
No description provided.