Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Intel's failings with buffer_storage #972

Merged
merged 1 commit into from Sep 5, 2014

Conversation

Sonicadvance1
Copy link
Contributor

No description provided.

@delroth
Copy link
Member

delroth commented Sep 5, 2014

OMGz, working around Intel driver failing? Page @neobrain.

But more seriously, LGTM. I'm curious as to whether that's a Dolphin issue or an Intel issue - at this point in time, our buffer storage code has been fairly well tested, so I'd be inclined to say it's Intel's fault...

@Sonicadvance1
Copy link
Contributor Author

Very much Intel's fault, it shouldn't fail on this buffer type.

@delroth
Copy link
Member

delroth commented Sep 5, 2014

Well, it could be that we're out of spec and that it's only showing now. That wouldn't be the first time this happens (for example, some of our GLES issues where very much this). Without more time spent debugging this I wouldn't 100% assume it's Intel's fault - but it's very, very likely.

@Sonicadvance1 Sonicadvance1 changed the title Work around Intel's failings with with buffer_storage Work around Intel's failings with buffer_storage Sep 5, 2014
@TurboK234
Copy link
Contributor

I reported this issue on Intel Graphics forums at https://communities.intel.com/thread/54819 , and they responded already, and the apparently have replicated the issue and are working on it. Good news!
I still find this workaround needed, since next Intel drivers might be some months from now. And this fix is driver version specific, isn't it?

@magcius
Copy link
Member

magcius commented Sep 5, 2014

Having this nice and contained inside DriverDetails makes this fine to me. Workarounds are only terrible if they have shitty code quality.

LGTM.

shuffle2 added a commit that referenced this pull request Sep 5, 2014
Work around Intel's failings with buffer_storage
@shuffle2 shuffle2 merged commit 0576046 into dolphin-emu:master Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants