Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamelist: Add 4x resolution nobanner image #9722

Merged
merged 2 commits into from
May 20, 2021

Conversation

Dentomologist
Copy link
Contributor

@Dentomologist Dentomologist commented May 18, 2021

When a game hasn't generated a GameList banner yet Dolphin displays an X placeholder image. This PR adds a 4x resolution version of the placeholder. It also improves centering of 2x and android banners, and adjusts 1x banner to increase consistency with other resolutions while maintaining sharpness.

@JosJuice
Copy link
Member

Please also update Source/Android/app/src/main/res/drawable/no_banner.png.

@Dentomologist
Copy link
Contributor Author

Android nobanner now changed as well.

@MayImilae
Copy link
Contributor

"Add antialiasing to 2x" it wasn't aliased, it was just sharp. :/ And I can provide a sharp 4x as well if you were worried about them matching.

@Dentomologist
Copy link
Contributor Author

So it turns out the 2x image already had antialiasing, but the color change used was subtle enough that I missed it. The 1x image had a larger color gap which I copied for the other resolutions, which ended up looking blurrier than what the 2x had before.

I've redone the other resolutions to match the 2x banner colors.

Note: The file size reduction isn't present in this version; I want to address any other issues first before redoing that.

@MayImilae
Copy link
Contributor

MayImilae commented May 19, 2021

Here you go, a full fixed set of nobanner icons. I created a true symmetrical version that fixes the weird positioning at any size, simply by being symmetrical. However this symmetry means that when the X meets, the joints are two pixels across. This is fine for the larger sizes, but this makes the original 1x version look worse (hence where the weirdness came from, I optimized for 1x). So for the best of both worlds, I made a new 1x icon that is non-symmetrical but gives the perfect single pixel intersection. And since these are straight from my source vector PSD so everything is perfectly crisp.

Optimized with optifine.

nobannerfixed.zip

Center @2x and android banners, and adjust @1x banner to improve
consistency with other resolutions while maintaining sharpness.

Images created by MayImilae
@Dentomologist
Copy link
Contributor Author

Thank you for the images, I've updated the build with them.

The 4x and android versions had their rightmost column slightly transparent, so I made them opaque and reran them through optipng.

@lioncash lioncash merged commit c5e8c84 into dolphin-emu:master May 20, 2021
@Dentomologist Dentomologist deleted the add_4x_nobanner_image branch July 17, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants