Updater: Escape HTML characters in commit descriptions #9749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
force-pushed
the
escape_update_commit_descriptions
branch
from
f314425
to
57f28b3
Compare
lioncash
reviewed
May 24, 2021
Dentomologist
force-pushed
the
escape_update_commit_descriptions
branch
2 times, most recently
from
2f3d66a
to
c40366c
Compare
Dentomologist
commented
May 24, 2021
Comment on lines
+678
to
+683
| for (const auto& [unescaped, escaped] : replacements) | ||
| { | ||
| html = ReplaceAll(html, unescaped, escaped); | ||
| } |
There was a problem hiding this comment.
I opted for readability over optimal performance here since anything that's generating HTML is unlikely to be on a hot path, but I'll change that if anyone wants me to.
leoetlino
reviewed
Jun 1, 2021
Dentomologist
force-pushed
the
escape_update_commit_descriptions
branch
from
e169065
to
99ed432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escapes &<>'" characters in the "Update available" modal's short commit descriptions.
Before:
After:
Fixes https://bugs.dolphin-emu.org/issues/12521