NetPlay: Refactor some functions into a common header #9763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
force-pushed
the
netplay-common-refactor
branch
from
e4f4149
to
de6cea2
Compare
leoetlino
reviewed
Jun 13, 2021
Techjar
force-pushed
the
netplay-common-refactor
branch
from
de6cea2
to
fd2c85c
Compare
leoetlino
reviewed
Jun 15, 2021
Source/Core/Core/NetPlayCommon.cpp
Outdated
|
|
||
| namespace NetPlay | ||
| { | ||
| static constexpr u32 LZO_IN_LEN = 1024 * 64; |
There was a problem hiding this comment.
constexpr variables at namespace scope already have internal linkage by default, so static is not required here.
Source/Core/Core/NetPlayCommon.cpp
Outdated
| namespace NetPlay | ||
| { | ||
| static constexpr u32 LZO_IN_LEN = 1024 * 64; | ||
| static constexpr u32 LZO_OUT_LEN = LZO_IN_LEN + (LZO_IN_LEN / 16) + 64 + 3; |
Techjar
force-pushed
the
netplay-common-refactor
branch
from
fd2c85c
to
afd6888
Compare
Techjar
force-pushed
the
netplay-common-refactor
branch
from
afd6888
to
3d5cf52
Compare
leoetlino
approved these changes
Jul 6, 2021
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some functions to a common place so that both sides can use them, which may be needed for future features. Also reduces the amount of code in the client and server a little bit. I also removed an unused struct, and renamed/restructured some things.