-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilesystemWidget: Show more information about partitions #9986
Conversation
Looks good to me. |
I like the idea, but I think the lines are rather long now. What do you think about getting rid of the initial "Partition %1", or maybe the title ID as ASCII at the end? |
The title ID as ASCII is interesting (it's where |
I worry a little that the number might be confusing. For instance, an update partition would normally be listed with one number saying "0" and one number saying "1", and I don't think it's clear to the user what these two numbers mean. (Though I guess it's true that even if we remove one of them, it's unclear what the remaining one means...) |
Yeah, actually, it's probably not useful information. Discs apparently have 4 lists of partitions (I don't really know why), so a single partition number isn't helpful for that purpose. DVDLowOpenPartition uses the offset to the partition, so it's not useful for understanding what games are doing either. I'll remove it. |
32443e1
to
86cf61a
Compare
With the "Partition %1" text removed, things fit in almost all cases, with the one exception of Super Smash Bros. Brawl's partitions, where they fit as long as none of the partitions are expanded, and the end gets truncated to make room for the size column if one is expanded (which I think is perfectly fine behavior). I've updated the screenshots to show this. |
86cf61a
to
0b86a03
Compare
The order in those screenshots seems a bit weird. The "Data Partition 0" being the most interresting one (usually with the index 0), but not being the first in the list feels off to me. Is this supposed to be in order of partition table? Not sure if the screenshots are up2date though. Edit: Oh, scratch that; its the partition type, i thought it was some sort of partition number or index. |
This adds the partition type, partition gameid, and partition title ID from the ticket into the filesystem widget. This is mostly just information that's interesting but not particularly useful, but it does help with seeing how the different values differ. Note that the partition gameid already shows up if you take screenshots while running something on a different partition (e.g. the Wii Fit Channel installer).
Screenshots