Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilesystemWidget: Show more information about partitions #9986

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

Pokechu22
Copy link
Contributor

@Pokechu22 Pokechu22 commented Aug 2, 2021

This adds the partition type, partition gameid, and partition title ID from the ticket into the filesystem widget. This is mostly just information that's interesting but not particularly useful, but it does help with seeing how the different values differ. Note that the partition gameid already shows up if you take screenshots while running something on a different partition (e.g. the Wii Fit Channel installer).

Screenshots

Super Mario Sunshine
Super Mario Galaxy
Wii Freeloader (US)
Wii Freeloader (EU)
Mario Kart Wii
Wii Fit
Wii Fit Plus
Super Smash Bros. Brawl
Super Smash Bros. Brawl - expanded

@JMC47
Copy link
Contributor

JMC47 commented Aug 2, 2021

Looks good to me.

@JosJuice
Copy link
Member

JosJuice commented Aug 2, 2021

I like the idea, but I think the lines are rather long now. What do you think about getting rid of the initial "Partition %1", or maybe the title ID as ASCII at the end?

@Pokechu22
Copy link
Contributor Author

The title ID as ASCII is interesting (it's where .UPE appears, for instance), but getting rid of the initial word "Partition" would work. (I think it might be useful to keep the number, if everything fits with it, but if there still isn't enough room I'll get rid of that too.)

@JosJuice
Copy link
Member

JosJuice commented Aug 2, 2021

I worry a little that the number might be confusing. For instance, an update partition would normally be listed with one number saying "0" and one number saying "1", and I don't think it's clear to the user what these two numbers mean. (Though I guess it's true that even if we remove one of them, it's unclear what the remaining one means...)

@Pokechu22
Copy link
Contributor Author

Yeah, actually, it's probably not useful information. Discs apparently have 4 lists of partitions (I don't really know why), so a single partition number isn't helpful for that purpose. DVDLowOpenPartition uses the offset to the partition, so it's not useful for understanding what games are doing either. I'll remove it.

@Pokechu22
Copy link
Contributor Author

With the "Partition %1" text removed, things fit in almost all cases, with the one exception of Super Smash Bros. Brawl's partitions, where they fit as long as none of the partitions are expanded, and the end gets truncated to make room for the size column if one is expanded (which I think is perfectly fine behavior). I've updated the screenshots to show this.

@BhaaLseN
Copy link
Member

BhaaLseN commented Aug 3, 2021

The order in those screenshots seems a bit weird. The "Data Partition 0" being the most interresting one (usually with the index 0), but not being the first in the list feels off to me. Is this supposed to be in order of partition table?

Not sure if the screenshots are up2date though.

Edit: Oh, scratch that; its the partition type, i thought it was some sort of partition number or index.

@Tilka Tilka merged commit 9c65519 into dolphin-emu:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants