Fix and extend frsp test #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Aug 6, 2022
cputest/frsp.cpp
Outdated
| @@ -15,9 +15,11 @@ static void FrspTest() | |||
| {0x000fffffffffffff, 0x0000000000000000, 0b000}, // largest double subnormal | |||
| {0x3690000000000000, 0x0000000000000000, 0b000}, // largest number rounded to zero | |||
| {0x3690000000000001, 0x36a0000000000000, 0b000}, // smallest positive single subnormal | |||
| {0x380fffffe0000001, 0x0000000000000000, 0b110}, // boundary of architecture-dependent behavior in non-IEEE mode | |||
There was a problem hiding this comment.
Personally I think it would make more sense to test this using the largest single subnormal (and equivalently the smallest single subnormal below), assuming that that does indeed produce the same result.
No idea why I didn't notice this before.
"f" is for singles, "d" is for doubles. Doesn't seem to matter much though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while so I'm not sure why I didn't notice this. The SNaN needs to turn into a QNaN.
All subtests succeed on real hardware. 0x380fffffffffffff -> 0x0000000000000000 currently fails in Dolphin.