Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method to add a commit and update working set together atomically #2032

Merged
merged 21 commits into from
Sep 13, 2021
Merged

Method to add a commit and update working set together atomically #2032

merged 21 commits into from
Sep 13, 2021

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Aug 18, 2021

No description provided.

@zachmu zachmu requested a review from reltuk September 3, 2021 22:12
reltuk
reltuk reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments!

go/libraries/doltcore/doltdb/doltdb.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/doltdb.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/doltdb.go Outdated Show resolved Hide resolved
go/store/datas/database_common.go Outdated Show resolved Hide resolved
go/store/datas/database_common.go Outdated Show resolved Hide resolved
go/store/types/value_store.go Show resolved Hide resolved
zachmu
zachmu commented Sep 8, 2021
View reviewed changes
Copy link
Member Author

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to get another draft out with some changes

go/libraries/doltcore/doltdb/doltdb.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/doltdb.go Outdated Show resolved Hide resolved
go/store/datas/database_common.go Outdated Show resolved Hide resolved
go/store/types/value_store.go Show resolved Hide resolved
go/store/datas/database_common.go Outdated Show resolved Hide resolved
reltuk
reltuk approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. A few questions / suggestions, but nothing big at all. Thanks for taking this on 👍

@zachmu zachmu merged commit a754593 into master Sep 13, 2021
@Hydrocharged Hydrocharged deleted the zachmu/transaction-merge branch December 8, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinaiRachakonda VinaiRachakonda VinaiRachakonda left review comments

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @reltuk @VinaiRachakonda