dolt dump should include views, triggers, and procedures
#3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Apr 15, 2022
| @@ -147,6 +148,66 @@ func InsertStatementPrefix(tableName string, tableSch schema.Schema) (string, er | |||
| return b.String(), nil | |||
| } | |||
|
|
|||
| // SqlRowAsCreateProcStmt Converts a Row into either a CREATE PROCEDURE statement | |||
There was a problem hiding this comment.
Mention that this expectes a row from the dolt_procedures table
| } | ||
|
|
||
| // SqlRowAsCreateFragStmt Converts a Row into either a CREATE TRIGGER or CREATE VIEW statement | ||
| func SqlRowAsCreateFragStmt(r sql.Row) (string, error) { |
There was a problem hiding this comment.
Mention that this needs a row from the dolt_schemas table
| @@ -160,6 +159,61 @@ teardown() { | |||
| dolt sql -q "CREATE VIEW view2 AS SELECT y FROM b;" | |||
| dolt sql -q "CREATE TRIGGER trigger2 AFTER INSERT ON a FOR EACH ROW INSERT INTO b VALUES (new.x * 2);" | |||
| dolt sql -q "INSERT INTO a VALUES (2);" | |||
| dolt sql -q "CREATE PROCEDURE p1 (in x int) select x from dual" | |||
There was a problem hiding this comment.
Need a test for a trigger that uses precedes or follows syntax:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for: #3159
instead of dumping certain dolt tables, create the views, triggers, and procedures.