Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sql server jwt auth #3867

Merged
merged 24 commits into from Jul 25, 2022
Merged

Sql server jwt auth #3867

merged 24 commits into from Jul 25, 2022

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Jul 20, 2022 •
edited

@tbantle22 tbantle22 marked this pull request as ready for review July 22, 2022 17:08
@tbantle22 tbantle22 requested a review from reltuk July 22, 2022 17:08
reltuk
reltuk reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far. Just a few comments.

go/cmd/dolt/commands/engine/jwtplugin.go Show resolved Hide resolved
go/cmd/dolt/commands/engine/testfiles/test_jwks.json Outdated Show resolved Hide resolved
go/libraries/utils/jwtauth/jwks.go Outdated Show resolved Hide resolved
go/libraries/utils/jwtauth/jwks.go Outdated Show resolved Hide resolved
integration-tests/bats/helper/gen_keys.bash Outdated Show resolved Hide resolved
@tbantle22 tbantle22 changed the base branch from main to tbantle22-e71f2c26 July 22, 2022 20:52
Base automatically changed from tbantle22-e71f2c26 to main July 22, 2022 21:16
@tbantle22 tbantle22 merged commit 10796c1 into main Jul 25, 2022
@tbantle22 tbantle22 deleted the taylor/jwtauth branch July 25, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbantle22 @reltuk