Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugin for other auth types #1123

Merged
merged 12 commits into from Jul 22, 2022
Merged

Allow plugin for other auth types #1123

merged 12 commits into from Jul 22, 2022

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Jul 19, 2022 •
edited

@tbantle22 tbantle22 requested review from zachmu and reltuk July 19, 2022 01:12
reltuk
reltuk reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good so far. Took a quick pass at some high level comments that will provide a bit of work. Please don't hesitate to follow up with any questions or push back if I missed something :).

enginetest/queries/priv_auth_queries.go Outdated Show resolved Hide resolved
enginetest/queries/priv_auth_queries.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
sql/mysql_db/mysql_db.go Outdated Show resolved Hide resolved
sql/mysql_db/mysql_db.go Outdated Show resolved Hide resolved
sql/mysql_db/jwt_auth.go Outdated Show resolved Hide resolved
sql/mysql_db/jwt_auth.go Outdated Show resolved Hide resolved
@tbantle22 tbantle22 marked this pull request as ready for review July 20, 2022 21:45
reltuk
reltuk reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple suggestions / questions.

sql/mysql_db/mysql_db.go Outdated Show resolved Hide resolved
sql/mysql_db/serial/mysql_db.go Outdated Show resolved Hide resolved
sql/plan/create_user_data.go Outdated Show resolved Hide resolved
@tbantle22 tbantle22 changed the title Cleartext and JWT auth Allow plugin for other auth types Jul 21, 2022
@tbantle22 tbantle22 mentioned this pull request Jul 21, 2022
Merged
reltuk
reltuk approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbantle22 tbantle22 merged commit e71f2c2 into main Jul 22, 2022
@tbantle22 tbantle22 deleted the taylor/jwt-auth branch July 22, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

@zachmu zachmu Awaiting requested review from zachmu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbantle22 @reltuk