Smart routing for sql command execution against running local servers #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
reviewed
May 17, 2023
There was a problem hiding this comment.
Generally looking good; the command startup feels like it's getting complex, but I guess that's unavoidable to some extent since we're including more logic. I held off from approving just to make sure I understood a couple questions/thoughts first.
Looks like there's just one failing BATS test left, too! 🎉
macneale4
force-pushed
the
macneale4/sql-local-remote
branch
from
b8f2033
to
4bd64a7
Compare
…where Use the ABS dataDir rather than the user provided value when looking for config and permissions files
Not all commands, or even all SQL statements need databases.
Renamed a variable to be more clear, and updated documentation for the --use-db flag.
Also, avoid using /tmp in tests. Could get polluted
macneale4
force-pushed
the
macneale4/sql-local-remote
branch
from
48f1778
to
d5214af
Compare
fulghum
approved these changes
May 19, 2023
There was a problem hiding this comment.
Logic looks good. I still think it's worth a little more time on the error messaging. Ideally the error message would be crystal clear about what's happening and include a concrete next step for how the user can correct it. Otherwise we get more support requests and customer get blocked in their usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
dolt sqlcommands are executed against a database which is in used by a sql server, connect to it through the sql port. Currently this does not support authenticated transport. If the root user is still active, we'll use that be default. Otherwise, the--userflag can be used to specify a user, but no authentication token is supported. That will come in the next round of changes.A step towards: #3922