Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart routing for sql command execution against running local servers #5966

Merged
merged 18 commits into from
May 22, 2023
Merged

Smart routing for sql command execution against running local servers #5966

merged 18 commits into from
May 22, 2023

Commits on May 18, 2023

  1. Bats tests for --data-dir and --use-db

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    63ee4eb View commit details
    Browse the repository at this point in the history

  2. Ensure we create the MultiEnv instance once in main, and use it every… 

    …where

Use the ABS dataDir rather than the user provided value when looking for config and permissions files
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4ff25db View commit details
    Browse the repository at this point in the history

  3. Fix broken test which allowed for non-existant --data-dir value

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    173a26c View commit details
    Browse the repository at this point in the history

  4. Use absolute paths for privledges and branch control files

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8fec67b View commit details
    Browse the repository at this point in the history

  5. Alter environment.go to have additional lock so we can grab the port

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    02a20e6 View commit details
    Browse the repository at this point in the history

  6. Enable calling local servers using the sql-server.lock file

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    958ccd8 View commit details
    Browse the repository at this point in the history

  7. Add the --verbose-engine-setup flag to see whats happening

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3f9dbbc View commit details
    Browse the repository at this point in the history

  8. New bats tests to verify we pick local or remote mode correctly

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2a70991 View commit details
    Browse the repository at this point in the history

  9. Allow for unresolved targetEnvironment. 

    Not all commands, or even all SQL statements need databases.
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    eaa4cdd View commit details
    Browse the repository at this point in the history

  10. Update sql-server.bats to reflect new behavior

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fe34fc9 View commit details
    Browse the repository at this point in the history

  11. Remove some debugging strings

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    406052a View commit details
    Browse the repository at this point in the history

  12. Name the sql-local-remote tests correctly

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    55b8b11 View commit details
    Browse the repository at this point in the history

  13. Reduce usage of first DoltEnv, and explicitely pass around current wo… 

    …rking directory
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a5d2310 View commit details
    Browse the repository at this point in the history

  14. Addressing PR Feedback 

    Renamed a variable to be more clear, and updated documentation for the --use-db flag.
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    e6945a0 View commit details
    Browse the repository at this point in the history

  15. [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda… 

    …te.sh
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    88d1cf3 View commit details
    Browse the repository at this point in the history

  16. Sort the DB names found in multirepo env 

    Also, avoid using /tmp in tests. Could get polluted
    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d5214af View commit details
    Browse the repository at this point in the history

  17. Print errors with some context about the remote server

    @macneale4
    macneale4 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4aeaf71 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Add temporary personal support while local/remote behavior is undocum… 

    …ented
    @macneale4
    macneale4 committed May 22, 2023
    Configuration menu
    Copy the full SHA
    cb8a970 View commit details
    Browse the repository at this point in the history