Moved AutoIncrementGetter to an internal interface #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
force-pushed
the
daylon/ft-autoincrement
branch
from
63a0d84
to
4d570c7
Compare
Hydrocharged
force-pushed
the
daylon/ft-autoincrement
branch
from
4d570c7
to
eccb361
Compare
zachmu
reviewed
Aug 21, 2023
| @@ -807,7 +807,11 @@ func (t *WritableDoltTable) GetNextAutoIncrementValue(ctx *sql.Context, potentia | |||
| return 0, err | |||
| } | |||
|
|
|||
| return ed.(sql.AutoIncrementGetter).GetNextAutoIncrementValue(ctx, potentialVal) | |||
| if multiTableEditor, ok := ed.(fulltext.MultiTableEditor); ok { | |||
| return multiTableEditor.PrimaryEditor().(writer.AutoIncrementGetter).GetNextAutoIncrementValue(ctx, potentialVal) | |||
There was a problem hiding this comment.
Can we make these an interface that embeds auto increment getter rather than having these typecasts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6543.
Companion to dolthub/go-mysql-server#1956.
The
AutoIncrementGetterwas moved from the editor to the table years ago, however the GMS interface remained. We had an internal reliance on the interface, even though GMS does not use it at all, so the interface has been moved to be an internal interface only. This fixes the panic as seen in the issue.