go/libraries/doltcore/sqle: DatabaseProvider: Fix a bug where a database created with call dolt_clone() would not be dropped until the server was restarted. #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase created with call dolt_clone() would not be dropped until the server was restarted. Fixes #7106.
macneale4
reviewed
Dec 6, 2023
| @@ -499,7 +499,7 @@ func (p *DoltDatabaseProvider) CloneDatabaseFromRemote( | |||
| return err | |||
| } | |||
|
|
|||
| return ConfigureReplicationDatabaseHook(ctx, p, dbName, dEnv) | |||
There was a problem hiding this comment.
This is happening where now? I only see it in the struct initialization, so I assume this is deferred until later.
There was a problem hiding this comment.
My read of this was that it was an error that we called ConfigureReplicationDatabaseHook directly here. We had already called InitDatabaseHook, which was responsible for this (and possible more hook configuration) on the newly created database. Since registerNewDatabase() also calls InitDatabaseHook, and there were direct calls to ConfigureReplicationDatabaseHook in the CreateDatabase path, removing this seemed correct to me.
macneale4
reviewed
Dec 6, 2023
Hydrocharged
deleted the
aaron/sqle-database-provider-clone-dbLocations-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7106.