Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default to text option for dolt table import #7278

Merged
merged 3 commits into from
Jan 9, 2024
Merged

default to text option for dolt table import #7278

merged 3 commits into from
Jan 9, 2024

Conversation

stephkyou
Copy link
Contributor

Adds the --all-text option to dolt table import which will default all columns to TEXT type.

Resolves: #6471

@stephkyou stephkyou marked this pull request as ready for review January 9, 2024 19:20
@stephkyou stephkyou requested a review from fulghum January 9, 2024 19:20
fulghum
fulghum approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work! 🚢

@stephkyou stephkyou merged commit 49aa415 into main Jan 9, 2024
18 checks passed
@stephkyou stephkyou deleted the steph/import-default-type branch January 9, 2024 21:06
@BrewTestBot BrewTestBot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: dolt table import add option to default to text/varchar type
2 participants
@stephkyou @fulghum