Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt table import --all-text correctly infers pk if none given #7284

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

stephkyou
Copy link
Contributor

dolt table import will use the first column in the import file as the primary key if none is explicitly defined. This change updates --all-text to also correctly do this inference.

@stephkyou stephkyou marked this pull request as ready for review January 9, 2024 23:26
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

go/cmd/dolt/commands/tblcmds/import.go Outdated Show resolved Hide resolved
@stephkyou stephkyou requested a review from fulghum January 9, 2024 23:40
Co-authored-by: Jason Fulghum <jason@dolthub.com>
@stephkyou stephkyou merged commit 84b9180 into main Jan 10, 2024
18 checks passed
@stephkyou stephkyou deleted the steph/import-default-fix branch January 10, 2024 01:13
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 0.5
batching batch sql 10000 1 0.1 1.1
batching by line sql 10000 1 0.11 1
blob 1 blob 200000 1 0.92 3.2 3.49
blob 2 blobs 200000 1 0.89 4.13 4.7
blob no blob 200000 1 0.89 1.31 1.42
col type datetime 200000 1 0.79 1.84 2.04
col type varchar 200000 1 0.67 2.03 2
config width 2 cols 200000 1 0.75 1.37 1.37
config width 32 cols 200000 1 1.86 1.45 2.54
config width 8 cols 200000 1 1 1.31 1.59
pk type float 200000 1 0.92 1.15 1.17
pk type int 200000 1 0.75 1.36 1.37
pk type varchar 200000 1 1.54 0.97 0.97
row count 1.6mm 1600000 1 5.56 1.52 1.56
row count 400k 400000 1 1.4 1.44 1.49
row count 800k 800000 1 2.8 1.48 1.53
secondary index four index 200000 1 3.64 1.08 0.91
secondary index no secondary 200000 1 0.88 1.38 1.45
secondary index one index 200000 1 1.1 1.54 1.53
secondary index two index 200000 1 1.94 1.24 1.14
sorting shuffled 1mm 1000000 0 5.31 1.8 1.82
sorting sorted 1mm 1000000 1 5.45 1.78 1.77

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.15
dolt_blame_commit_filter system table 2.77
dolt_commit_ancestors_commit_filter system table 0.87
dolt_commits_commit_filter system table 0.9
dolt_diff_log_join_from_commit system table 1.71
dolt_diff_log_join_to_commit system table 1.71
dolt_diff_table_from_commit_filter system table 1.17
dolt_diff_table_to_commit_filter system table 1.13
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.46
dolt_log_commit_filter system table 0.9

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.72
adds_updates_deletes 60000 60000 60000 3.77
deletes_only 0 60000 0 1.88
updates_only 0 0 60000 2.41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants