Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed RootValue into an interface #7829

Merged
merged 2 commits into from
May 8, 2024
Merged

Changed RootValue into an interface #7829

merged 2 commits into from
May 8, 2024

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented May 7, 2024 •
edited

Companion:

This changes the RootValue into an interface. Every function that seems unique to Dolt's RootValue has been changed into a function variable, with the variable being overwritten from Doltgres to point to a different function.

@Hydrocharged Hydrocharged requested review from zachmu and reltuk May 7, 2024 12:56
@Hydrocharged Hydrocharged marked this pull request as ready for review May 7, 2024 12:56
@Hydrocharged Hydrocharged mentioned this pull request May 7, 2024
Merged
@coffeegoddd
Copy link
Contributor

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f96e43a ok 5937457
version total_tests
f96e43a 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, see comments on doltgres side

go/libraries/doltcore/doltdb/root_val.go Show resolved Hide resolved
go/libraries/doltcore/doltdb/root_val.go Show resolved Hide resolved
go/store/types/serial_message.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged removed the request for review from reltuk May 8, 2024 12:50
@Hydrocharged Hydrocharged merged commit 09cc98d into main May 8, 2024
20 checks passed
@Hydrocharged Hydrocharged deleted the daylon/root-value-interface branch May 8, 2024 12:51
@coffeegoddd
Copy link
Contributor

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d204d27 ok 5937457
version total_tests
d204d27 5937457
correctness_percentage
100.0

This was referenced May 8, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hydrocharged @coffeegoddd @zachmu