Added Doltgres-implementation of RootValue #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
force-pushed
the
daylon/new-root-value
branch
from
89569ca
to
26161c1
Compare
zachmu
approved these changes
May 7, 2024
Hydrocharged
force-pushed
the
daylon/new-root-value
branch
from
f37cdb6
to
e266bb4
Compare
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion:
This is Doltgres' implementation of
RootValue. For now, it's essentially taken wholesale from Dolt as a starting point. Of note, we probably want to at least get something different for our collation values sometime soon. Also, we're using the same serial identifier for root values between Doltgres and Dolt. This simplifies a good bit of code in Dolt, so taking on the naming requirement seems well worth it.