Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BOOLEAN and BOOLEAN[] types #120

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Added BOOLEAN and BOOLEAN[] types #120

merged 1 commit into from
Feb 7, 2024

Conversation

Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Feb 5, 2024

This adds rough support for both BOOLEAN and BOOLEAN[] types. This is primarily to show a working implementation of the new ExtendedType interface that was added to GMS to support these new types, demonstrating that we can now add standard PostgreSQL types, as well as array types (along with accompanying functionality, such as ARRAY[] support).

Related PRs:

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/types/bool.go Show resolved Hide resolved
server/types/bool.go Show resolved Hide resolved
server/types/bool_array.go Show resolved Hide resolved
server/types/bool_array.go Show resolved Hide resolved
server/types/bool_array.go Show resolved Hide resolved
server/types/serialization.go Show resolved Hide resolved
server/types/serialization.go Show resolved Hide resolved
utils/max.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 35d9c85 into main Feb 7, 2024
7 checks passed
@Hydrocharged Hydrocharged deleted the daylon/super-type branch February 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants