-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP pg_catalog
support
#190
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 9e60579 Author: Taylor Bantle <taylor@dolthub.com> Date: Fri May 3 10:58:36 2024 -0700 Types fixes commit 7cdace1 Merge: 299c138 92d9782 Author: Taylor Bantle <taylor@dolthub.com> Date: Fri May 3 10:56:12 2024 -0700 Merge branch 'taylor/pg-catalog' into taylor/pg-cat-2 commit 299c138 Author: Taylor Bantle <taylor@dolthub.com> Date: Fri Apr 26 15:20:46 2024 -0700 Fix nullable columns, add some TODOs commit 73d27eb Author: Taylor Bantle <taylor@dolthub.com> Date: Thu Apr 25 16:40:06 2024 -0700 Update more pg_catalog table type todos commit 04215ae Author: Taylor Bantle <taylor@dolthub.com> Date: Thu Apr 25 16:24:11 2024 -0700 Remove int and float todos commit b8c8353 Author: Taylor Bantle <taylor@dolthub.com> Date: Thu Apr 25 15:17:07 2024 -0700 Bytea exists already commit 43dbbd1 Author: Taylor Bantle <taylor@dolthub.com> Date: Thu Apr 25 14:57:56 2024 -0700 Add more pg_catalog schemas, comment missing types commit 85f38fb Author: Taylor Bantle <taylor@dolthub.com> Date: Thu Apr 25 10:49:56 2024 -0700 More pg_catalog progress
tbantle22
force-pushed
the
taylor/pg-catalog
branch
from
May 3, 2024 18:00
13fdbf6
to
7acb1f1
Compare
zachmu
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, no real notes except to add more tests of the tables implemented so far.
Closing this in favor of daylon's implementation. Will make a new PR with the schemas from this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMS PR: dolthub/go-mysql-server#2471
Dolt PR: dolthub/dolt#7779