Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comparisons for JSONB #319

Merged
merged 1 commit into from
May 29, 2024
Merged

Added comparisons for JSONB #319

merged 1 commit into from
May 29, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This adds comparisons for jsonb. In the original JSON PR, I mistakenly only checked if json had comparisons, and that type does not. jsonb, however, does have comparisons, so this implements those. In addition, I've added a massive collection of rows that it properly sorts over. Test results were lifted straight from a Postgres 15 server to ensure accuracy.

@Hydrocharged Hydrocharged requested a review from zachmu May 29, 2024 09:10
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit 0c4168c into main May 29, 2024
9 checks passed
@Hydrocharged Hydrocharged deleted the daylon/jsonb-compare branch May 29, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants