-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some supported columns for STATISTICS
and COLUMNS
info schema tables
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of nice changes in here @jennifersp! Keep 'em coming! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sub_part
forSTATISTICS
table.column_default
,datetime_precision
,extra
and other columns forCOLUMNS
table.cardinality
column forSTATISTICS
table as it's not supported in Dolt yet.privileges
column forCOLUMNS
table for now. (in progress)FunctionName()
method to create the string statement of the function itself. TheFunctionName()
method returns the name of the function in all lower cases. This makes it so that all Dolt supported MySQL functions are consistent to what MySQL returns for queries such asSHOW CREATE TABLE
or thecolumn_default
ofinformation_schema.COLUMNS
table.Notes:
BOOL
andTINYINT
data types the same withINT8
, but MySQL explicitly definesBOOL
astinyint(1)
, which is different fromtinyint
forTINYINT
data types.COLUMNS
table yet.