Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some supported columns for STATISTICS and COLUMNS info schema tables #1480

Merged
merged 15 commits into from
Dec 19, 2022

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Dec 15, 2022

  • Added sub_part for STATISTICS table.
  • Fixed column_default, datetime_precision, extra and other columns for COLUMNS table.
  • Skipped cardinality column for STATISTICS table as it's not supported in Dolt yet.
  • Skipped privileges column for COLUMNS table for now. (in progress)
  • Modified all Dolt supported MySQL functions to use its FunctionName() method to create the string statement of the function itself. The FunctionName() method returns the name of the function in all lower cases. This makes it so that all Dolt supported MySQL functions are consistent to what MySQL returns for queries such as SHOW CREATE TABLE or the column_default of information_schema.COLUMNS table.

Notes:

  • Dolt does not support Time length yet.
  • Dolt currently handles BOOL and TINYINT data types the same with INT8, but MySQL explicitly defines BOOL as tinyint(1), which is different from tinyint for TINYINT data types.
  • View columns are not available in COLUMNS table yet.

@fulghum fulghum self-requested a review December 16, 2022 21:15
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nice changes in here @jennifersp! Keep 'em coming! 🚢

sql/information_schema/columns_table.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit 47116e7 into main Dec 19, 2022
@jennifersp jennifersp deleted the jennifer/info branch December 19, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants