Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if privilegeSet is nil, return empty row for info schema tables #1539

Merged
merged 2 commits into from
Jan 17, 2023
Merged

if privilegeSet is nil, return empty row for info schema tables #1539

merged 2 commits into from
Jan 17, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Jan 17, 2023 •
edited
Loading

  • privilegeSet was nil for ld repository tests as there were no privileges granted and was trying to test on information_schema.views table.
  • the now exported method is used in ld to grant all privileges for the test user

fixes test in https://github.com/dolthub/ld/pull/12642

Hydrocharged
Hydrocharged approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennifersp jennifersp merged commit 00346c4 into main Jan 17, 2023
@jennifersp jennifersp deleted the jennifer/fix-for-ld branch January 17, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @Hydrocharged