Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes from diffs between mysql and dolt info_schema dumps #1552

Merged
merged 8 commits into from
Jan 25, 2023
Merged

fixes from diffs between mysql and dolt info_schema dumps #1552

merged 8 commits into from
Jan 25, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Jan 24, 2023 •
edited
Loading

  • Fixed incorrect values in Dolt that did not match MySQL result on information_schema dump
  • Unskipped fixed test

@jennifersp jennifersp linked an issue Jan 24, 2023 that may be closed by this pull request
Support the table_rows column with the information_schema.TABLES keyword dolthub/dolt#3216
Closed
fulghum
fulghum approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes! Very cool that you were able to find some of these with the info_schema dump/import/diff process you built. 🙌

sql/information_schema/information_schema.go Outdated Show resolved Hide resolved
sql/information_schema/routines_table.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit d5666d9 into main Jan 25, 2023
@jennifersp jennifersp deleted the jennifer/info-schema-fix branch January 25, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the table_rows column with the information_schema.TABLES keyword
2 participants
@jennifersp @fulghum