fixes handling of null set values #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Jan 27, 2023
sql/types/set_test.go
Outdated
| tests := []struct { | ||
| vals []string | ||
| collation sql.CollationID | ||
| val string |
There was a problem hiding this comment.
Looks like the val field is never used and could be removed.
| @@ -172,6 +172,7 @@ func TestSetConvert(t *testing.T) { | |||
| {[]string{"one", "two"}, sql.Collation_utf8mb4_general_ci, "ONE", "one", false}, | |||
| {[]string{"ONE", "two"}, sql.Collation_utf8mb4_general_ci, "one", "ONE", false}, | |||
|
|
|||
| {[]string{"one", "two"}, sql.Collation_Default, ",one,two", nil, true}, | |||
There was a problem hiding this comment.
Might be nice to add one more test entry for a non-error condition for a set that does allow the empty string (just because I noticed there's no coverage for that in these tests yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null set values were being ignored completely. This PR fixes this issue and addresses the display issue which shows an extra comma when null set values are present in multi-member set values.
fixes: dolthub/dolt#4966