-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parser interface in engine #2486
Conversation
41b3607
to
ae1afe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parser interface looks good, putting it on the context looks bad.
It can go on the catalog if it needs to, but it probably shouldn't. The main place that needs it is the plan builder, it should be a field there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just a couple pieces of feedback
This PR creates
sql.Parser
interface. This interface is defined in the engine and it should be used rather than using mysql parser directly.Added
GlobalParser
variable to expose Doltgres parser for parsing view definition for now. It can also be used in places that needs doltgres-specific syntax parsing.