Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CREATE VIEW #168

Merged
merged 32 commits into from
May 9, 2024
Merged

support CREATE VIEW #168

merged 32 commits into from
May 9, 2024

Conversation

Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing we need to add are tests that make use of some Postgres-specific syntax. One example is CREATE VIEW v AS SELECT pk::INT2 FROM t1 ORDER BY pk;. Just a few different ones, as it looks like all of the defined views are fully valid MySQL statements, so we need to guarantee that it succeeds for invalid MySQL statements that are valid PostgreSQL statements.

Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just have a big question regarding the usage of the vitess parser instead of our Postgres parser.

testing/go/create_view_test.go Show resolved Hide resolved
server/parser.go Outdated Show resolved Hide resolved
server/parser.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit 8639d45 into main May 9, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/create-view branch May 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants