Expand literals in comparisons when safe #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
May 7, 2024
sql/planbuilder/scalar.go
Outdated
| } | ||
|
|
||
| if rightLit != nil && leftGf != nil { | ||
| if types.IsSigned(left.Type()) && types.IsSigned(right.Type()) { |
There was a problem hiding this comment.
Seems kind of over specified? If this is a good idea then it's probably a good idea for other types too
There was a problem hiding this comment.
I made it more general in a way that I think is easy to understand as safe. Types are similar classes and column type is wider than literal. Crossing those two boundaries is doable but trickier, less common, and can depend on the expression type.
|
test bump correctness looks good, shipping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.