Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andy/database provider #486

Merged
merged 4 commits into from Jun 28, 2021
Merged

Andy/database provider #486

merged 4 commits into from Jun 28, 2021

Conversation

andy-wm-arthur
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur commented Jun 28, 2021

Adds a DatabaseProvider abstraction, allowing integrators to add their own logic to database resolution

@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review June 28, 2021 22:54
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty reasonable

// AllDatabases returns a slice of all Databases in the provider.
AllDatabases() []Database

// AddDatabase adds a new Database to the provider's collection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications should be a sub-interface

@andy-wm-arthur andy-wm-arthur merged commit a94583c into master Jun 28, 2021
@Hydrocharged Hydrocharged deleted the andy/database-provider branch December 8, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants