Zachmu/logger #536
Merged
Zachmu/logger #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
approved these changes
Aug 31, 2021
Comment on lines
135
to
+137
| s.mu.Lock() | ||
| sess, ok := s.sessions[conn.ConnectionID] | ||
| ir := s.idxRegs[conn.ConnectionID] | ||
| vr := s.viewRegs[conn.ConnectionID] | ||
| if !ok { | ||
| var err error | ||
| sess, ir, vr, err = s.builder(ctx, conn, s.addr) | ||
| s.mu.Unlock() |
There was a problem hiding this comment.
Not an actionable comment, but just something I wish Go had. In C# they have the lock command where some block of code executes under a mutex, guaranteeing that the mutex is always released once leaving the block's scope. In Go we have to declare a function and use defer to get something equivalent, while adding some pains with return handling and whatnot. Just wishing...
There was a problem hiding this comment.
Yeah go locking is lame, I blame Rob Pike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.