Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CREATE DATABASE to integrators #547

Merged
merged 13 commits into from
Sep 9, 2021
Merged

Conversation

andy-wm-arthur
Copy link
Contributor

Remove AddDatabase functionality from Catalog and DatabaseProvider. Must have a DatabaseProvider with a static set of Databases to construct a Catalog.

New Databases can be created with CreateDatabase, which is now an integrator function.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

_example/main.go Outdated Show resolved Hide resolved
sql/catalog.go Show resolved Hide resolved
sql/core.go Outdated Show resolved Hide resolved
@andy-wm-arthur andy-wm-arthur merged commit b172dcf into master Sep 9, 2021
@Hydrocharged Hydrocharged deleted the andy/create-database branch December 8, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants