Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse empty begin end block in trigger #298

Merged
merged 2 commits into from
Jan 4, 2024
Merged

parse empty begin end block in trigger #298

merged 2 commits into from
Jan 4, 2024

Conversation

jycor
Copy link

@jycor jycor commented Jan 3, 2024 •
edited

14 SQL correctness tests are failing because we throw syntax errors on queries like this:

CREATE TRIGGER t1r1 AFTER UPDATE ON t1 FOR EACH ROW BEGIN END;

@jycor jycor requested a review from zachmu as a code owner January 3, 2024 22:02
fulghum
fulghum approved these changes Jan 4, 2024
View reviewed changes
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jycor jycor merged commit 4b296d3 into main Jan 4, 2024
4 checks passed
@jycor jycor deleted the james/trigger branch January 4, 2024 22:00
This was referenced Jan 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @fulghum