fix: handle none value #468
Merged
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yktakaha4
commented
Jan 29, 2024
Comment on lines
+31
to
+34
| <reason> | ||
| <type></type> | ||
| <comment></comment> | ||
| </reason> |
There was a problem hiding this comment.
An error occurs when processing such data.
seanthegeek
added a commit
that referenced
this pull request
Feb 20, 2024
- Add support for SMTP TLS reports (PR #453 closes issue #71) - Do not replace content in forensic samples (fix #403) - Pin `msgraph-core` dependency at version `0.2.2` until Microsoft provides better documentation (PR #466 Close [#464](#464)) - Properly handle base64-encoded email attachments (PR #453) - Do not crash when attempting to parse invalid email content (PR #453) - Ignore errors when parsing text-based forensic reports (PR #460) - Add email date to email processing debug logs (PR #462) - Set default batch size to 10 to match the documentation (PR #465) - Properly handle none values (PR #468) - Add Gmail pagination (PR #469) - Use the correct `msgraph` scope (PR #471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you to all the maintainers.
In my use case, I encountered the below error.
It turned out that the None check was missing in the following places, so I fixed it.
I've also added test data to verify the fix.
parsedmarc/parsedmarc/__init__.py
Line 510 in 7d2b431
I believe that the CI failure will be resolved by merging the PR below.
#466