Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markdown requirement from <3.4.0,>=3.3.3 to >=3.3.3,<3.5.0 #21

Closed
wants to merge 2 commits into from
Closed

Update markdown requirement from <3.4.0,>=3.3.3 to >=3.3.3,<3.5.0 #21

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 19, 2023 •
edited

Updates the requirements on markdown to permit the latest version.

Changelog

Sourced from markdown's changelog.

title: Release Notes for v2.6

Python-Markdown 2.6 Release Notes

We are pleased to release Python-Markdown 2.6 which adds a few new features and fixes various bugs. See the list of changes below for details.

Python-Markdown version 2.6 supports Python versions 2.7, 3.2, 3.3, and 3.4 as well as PyPy.

Backwards-incompatible Changes

safe_mode Deprecated

Both safe_mode and the associated html_replacement_text keywords are deprecated in version 2.6 and will raise a DeprecationWarning. The safe_mode and html_replacement_text keywords will be ignored in the next release. The so-called "safe mode" was never actually "safe" which has resulted in many people having a false sense of security when using it. As an alternative, the developers of Python-Markdown recommend that any untrusted content be passed through an HTML sanitizer (like [Bleach]) after being converted to HTML by markdown. In fact, [Bleach Whitelist] provides a curated list of tags, attributes, and styles suitable for filtering user-provided HTML using bleach.

If your code previously looked like this:

html = markdown.markdown(text, safe_mode=True)

Then it is recommended that you change your code to read something like this:

import bleach
from bleach_whitelist import markdown_tags, markdown_attrs
html = bleach.clean(markdown.markdown(text), markdown_tags, markdown_attrs)

If you are not interested in sanitizing untrusted text, but simply desire to escape raw HTML, then that can be accomplished through an extension which removes HTML parsing:

from markdown.extensions import Extension
class EscapeHtml(Extension):
def extendMarkdown(self, md, md_globals):
del md.preprocessors['html_block']
del md.inlinePatterns['html']
</tr></table>

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update markdown requirement from <3.4.0,>=3.3.3 to >=3.3.3,<3.5.0
5323512 
Updates the requirements on [markdown](https://github.com/Python-Markdown/markdown) to permit the latest version.
- [Changelog](https://github.com/Python-Markdown/markdown/blob/master/docs/change_log/release-2.6.md)
- [Commits](Python-Markdown/markdown@3.3.3...3.4.3)

---
updated-dependencies:
- dependency-name: markdown
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 19, 2023
@dependabot dependabot bot requested a review from domdfcoding May 19, 2023 10:42
@repo-helper repo-helper bot added failure: flake8 The Flake8 check is failing. failure: mypy The mypy check is failing. failure: Linux The Linux tests are failing. failure: Windows The Windows tests are failing. labels May 19, 2023
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 31, 2023

A newer version of markdown exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@domdfcoding
Copy link
Owner

@dependabot recreate

@dependabot Dependabot
Copy link
Author

dependabot bot commented on behalf of github Nov 20, 2023

Superseded by #25.

@dependabot dependabot bot closed this Nov 20, 2023
@dependabot dependabot bot deleted the dependabot/pip/markdown-gte-3.3.3-and-lt-3.5.0 branch November 20, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domdfcoding domdfcoding Awaiting requested review from domdfcoding

Assignees

@domdfcoding domdfcoding

Labels
dependencies Pull requests that update a dependency file failure: flake8 The Flake8 check is failing. failure: Linux The Linux tests are failing. failure: mypy The mypy check is failing. failure: Windows The Windows tests are failing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@domdfcoding