Add support for sinon v4

[Yeti-or]

No description provided.

[domenic]

As you can see, the test suite fails on Sinon v4, so this is not mergeable.

[Yeti-or]

Yeah, I will investigate failing tests tomorrow, it was ok on local machine

…

On Tue, 26 Sep 2017 at 16:52, Domenic Denicola ***@***.***> wrote: As you can see <https://travis-ci.org/domenic/sinon-chai/builds/279896519?utm_source=github_status&utm_medium=notification>, the test suite fails on Sinon v4, so this is not mergeable. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABur3MVOwCajJcI883nY4U7bIbRE__-wks5smQGEgaJpZM4PkAYm> .

[daffl]

Looks like another dependency (nise ) not being installed. I had a similar problem in #108. Adding it to devDependencies will probably fix it but I'm still not sure why this keeps happening.

[Yeti-or]

I think it's a bug in npm and it was fixed in 5.4.2: https://github.com/npm/npm/releases/tag/v5.4.2

[Yeti-or]

steps:

$ node --version
v8.5.0
$ npm --version
5.3.0
npm install
mocha — ok
npm install sinon@^3.0.0
mocha — fail
Error: Cannot find module 'nise'

Because in nise package.json there is no more `main` field

[Yeti-or]

@domenic tests are green, so is it mergeable now ?

[griest024]

@Yeti-or it could be related to sinonjs/nise#10

[domenic]

Nice hack. Can we remove lolex too then?

[Yeti-or]

@domenic yes we can