Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module entry point #132

Closed
griest024 opened this issue Sep 28, 2017 · 1 comment · Fixed by #133
Closed

add module entry point #132

griest024 opened this issue Sep 28, 2017 · 1 comment · Fixed by #133

Comments

@griest024
Copy link
Contributor

importing lolex in certain module systems will throw Uncaught ReferenceError: global is not defined and adding a module entry point in package.json will fix this.
griest024 added a commit to griest024/lolex that referenced this issue Sep 28, 2017
@griest024
add module entry point
ff70973 
fixes sinonjs#132
@griest024 griest024 mentioned this issue Sep 28, 2017
Merged
@fatso83
Copy link
Contributor

fatso83 commented Sep 28, 2017 •
edited

Could you give some more details? Which systems are this, and can you point to an example config? Seems related to sinonjs/nise#10.

fatso83 pushed a commit that referenced this issue Oct 3, 2017
@griest024 @fatso83
add module entry point (#133)
363c242 
fixes #132
fatso83 added a commit to fatso83/sinon that referenced this issue Oct 4, 2017
@fatso83
Upgrade nise and lolex versions
f2252b4 
Related to domenic/sinon-chai#111,
sinonjs/nise#10 and sinonjs/fake-timers#132
@fatso83 fatso83 mentioned this issue Oct 4, 2017
Merged
franck-romano pushed a commit to franck-romano/sinon that referenced this issue Oct 1, 2019
@fatso83
Upgrade nise and lolex versions
921c132 
Related to domenic/sinon-chai#111,
sinonjs/nise#10 and sinonjs/fake-timers#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add module entry point griest024/lolex
2 participants
@fatso83 @griest024