Skip to content

Commit

Permalink
[libc++] Un-xfail module tests in picolibc tests
Browse files Browse the repository at this point in the history
Some of the module tests now pass after picolibc update.
llvm#77908

The remaining tests fail and are now set to xfail on picolibc
specifically.
  • Loading branch information
domin144 committed Jan 18, 2024
1 parent 18d0a7e commit 95e0157
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 1 deletion.
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 4 additions & 0 deletions libcxx/test/libcxx/selftest/modules/std.compat-module.sh.cpp
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// Make sure that the compile flags contain the expected elements.
// The tests only look for the expected components and not the exact flags.
// Otherwise changing the location of the module would break this test.
Expand Down
4 changes: 4 additions & 0 deletions libcxx/test/std/modules/std.compat.pass.cpp
Expand Up @@ -12,6 +12,10 @@

// XFAIL: has-no-cxx-module-support

// picolibc does not provide the required timespec_get function, and the
// "using-if-exists" mechanism apparently did not work here.
// XFAIL: LIBCXX-PICOLIBC-FIXME

// A minimal test to validate import works.

// MODULE_DEPENDENCIES: std.compat
Expand Down
1 change: 0 additions & 1 deletion libcxx/utils/libcxx/test/features.py
Expand Up @@ -324,7 +324,6 @@ def _getAndroidDeviceApi(cfg):
# This is not allowed per C11 7.1.2 Standard headers/6
# Any declaration of a library function shall have external linkage.
when=lambda cfg: "__ANDROID__" in compilerMacros(cfg)
or "__PICOLIBC__" in compilerMacros(cfg)
or platform.system().lower().startswith("aix")
# Avoid building on platforms that don't support modules properly.
or not hasCompileFlag(cfg, "-Wno-reserved-module-identifier"),
Expand Down

0 comments on commit 95e0157

Please sign in to comment.