[libc++] tests with picolibc: update picolibc #77908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated picolibc version has "isblank" function with external linkage. This is required for C++ modules support.[1] [1] llvm#76980
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Dominik Wójt (domin144) ChangesThe updated picolibc version has "isblank" function with external linkage. This is required for C++ modules support.[1] [1] #76980 Full diff: https://github.com/llvm/llvm-project/pull/77908.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/build-picolibc.sh b/libcxx/utils/ci/build-picolibc.sh
index 078c2bdf5ebccc..713e2773547689 100755
--- a/libcxx/utils/ci/build-picolibc.sh
+++ b/libcxx/utils/ci/build-picolibc.sh
@@ -73,8 +73,9 @@ mkdir -p "${picolibc_build_dir}"
# Following changes are required and were introduced after version 1.8.5:
# - updated semihost arguments handling,
# - added missing macros in stdio.h
+# - external linkage for isblank
# Version following 1.8.5, was not released by the time of writing.
-picolibc_commit="4b9b8ef01d18cf0563348ad4af4ae89a7277e7ca"
+picolibc_commit="04a90c56d7aac61880f205ec29b3dce6a9de0342"
curl -L "https://github.com/picolibc/picolibc/archive/${picolibc_commit}.zip" --output "${picolibc_source_dir}/picolibc.zip"
unzip -q "${picolibc_source_dir}/picolibc.zip" -d "${picolibc_source_dir}"
mv "${picolibc_source_dir}/picolibc-${picolibc_commit}"/* "${picolibc_source_dir}"
|
mordante
approved these changes
Jan 12, 2024
domin144
added a commit
to domin144/llvm-project
that referenced
this pull request
Jan 18, 2024
Some of the module tests now pass after picolibc update. llvm#77908 The remaining tests fail and are now set to xfail on picolibc specifically.
mordante
pushed a commit
that referenced
this pull request
Jan 18, 2024
Some of the module tests now pass after picolibc update. #77908 The remaining tests fail and are now set to xfail on picolibc specifically.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
The updated picolibc version has "isblank" function with external linkage. This is required for C++ modules support. This should solve all the problems reported in llvm#76980, but we'll wait to validate this with the modules build without closing that issue.
blueboxd
pushed a commit
to blueboxd/libcxx
that referenced
this pull request
Feb 1, 2024
Some of the module tests now pass after picolibc update. llvm/llvm-project#77908 The remaining tests fail and are now set to xfail on picolibc specifically. NOKEYCHECK=True GitOrigin-RevId: 7f0515323670459b8376b866bc73a448f0a5aa6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated picolibc version has "isblank" function with external linkage. This is required for C++ modules support.[1]
[1] #76980