Skip to content

Commit

Permalink
fixed problem with small and big bar without expanding option
Browse files Browse the repository at this point in the history
  • Loading branch information
@dominicrico
dominicrico committed Jul 14, 2015
1 parent b1f3d62 commit 4ec1f8c
Show file tree
Hide file tree
Showing 7 changed files with 227 additions and 225 deletions.
28 changes: 14 additions & 14 deletions coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<div class="header low">
<h1>Code coverage report for <span class="entity">All files</span></h1>
<h2>
Statements: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">16.09% <small>(14 / 87)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">43.75% <small>(7 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Statements: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">18.56% <small>(18 / 97)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">56.25% <small>(9 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
</h2>
<div class="path"></div>
Expand All @@ -42,23 +42,23 @@ <h2>
</thead>
<tbody><tr>
<td class="file low" data-value="src/"><a href="src/index.html">src/</a></td>
<td data-value="32.22" class="pic low"><span class="cover-fill" style="width: 32px;"></span><span class="cover-empty" style="width:68px;"></span></td>
<td data-value="32.22" class="pct low">32.22%</td>
<td data-value="90" class="abs low">(29&nbsp;/&nbsp;90)</td>
<td data-value="16.09" class="pct low">16.09%</td>
<td data-value="87" class="abs low">(14&nbsp;/&nbsp;87)</td>
<td data-value="43.75" class="pct low">43.75%</td>
<td data-value="16" class="abs low">(7&nbsp;/&nbsp;16)</td>
<td data-value="32.22" class="pct low">32.22%</td>
<td data-value="90" class="abs low">(29&nbsp;/&nbsp;90)</td>
<td data-value="43.33" class="pic low"><span class="cover-fill" style="width: 43px;"></span><span class="cover-empty" style="width:57px;"></span></td>
<td data-value="43.33" class="pct low">43.33%</td>
<td data-value="90" class="abs low">(39&nbsp;/&nbsp;90)</td>
<td data-value="18.56" class="pct low">18.56%</td>
<td data-value="97" class="abs low">(18&nbsp;/&nbsp;97)</td>
<td data-value="56.25" class="pct medium">56.25%</td>
<td data-value="16" class="abs medium">(9&nbsp;/&nbsp;16)</td>
<td data-value="43.33" class="pct low">43.33%</td>
<td data-value="90" class="abs low">(39&nbsp;/&nbsp;90)</td>
</tr>

</tbody>
</table>
</div>
</div>
<div class="footer">
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:14:21 GMT+0200 (CEST)</div>
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:57:46 GMT+0200 (CEST)</div>
</div>
<script src="prettify.js"></script>
<script>
Expand Down
28 changes: 14 additions & 14 deletions coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/src/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<div class="header low">
<h1>Code coverage report for <span class="entity">src/</span></h1>
<h2>
Statements: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">16.09% <small>(14 / 87)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">43.75% <small>(7 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Statements: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">18.56% <small>(18 / 97)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">56.25% <small>(9 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
</h2>
<div class="path"><a href="../index.html">All files</a> &#187; src/</div>
Expand All @@ -42,23 +42,23 @@ <h2>
</thead>
<tbody><tr>
<td class="file low" data-value="ng-reading-indicator.js"><a href="ng-reading-indicator.js.html">ng-reading-indicator.js</a></td>
<td data-value="32.22" class="pic low"><span class="cover-fill" style="width: 32px;"></span><span class="cover-empty" style="width:68px;"></span></td>
<td data-value="32.22" class="pct low">32.22%</td>
<td data-value="90" class="abs low">(29&nbsp;/&nbsp;90)</td>
<td data-value="16.09" class="pct low">16.09%</td>
<td data-value="87" class="abs low">(14&nbsp;/&nbsp;87)</td>
<td data-value="43.75" class="pct low">43.75%</td>
<td data-value="16" class="abs low">(7&nbsp;/&nbsp;16)</td>
<td data-value="32.22" class="pct low">32.22%</td>
<td data-value="90" class="abs low">(29&nbsp;/&nbsp;90)</td>
<td data-value="43.33" class="pic low"><span class="cover-fill" style="width: 43px;"></span><span class="cover-empty" style="width:57px;"></span></td>
<td data-value="43.33" class="pct low">43.33%</td>
<td data-value="90" class="abs low">(39&nbsp;/&nbsp;90)</td>
<td data-value="18.56" class="pct low">18.56%</td>
<td data-value="97" class="abs low">(18&nbsp;/&nbsp;97)</td>
<td data-value="56.25" class="pct medium">56.25%</td>
<td data-value="16" class="abs medium">(9&nbsp;/&nbsp;16)</td>
<td data-value="43.33" class="pct low">43.33%</td>
<td data-value="90" class="abs low">(39&nbsp;/&nbsp;90)</td>
</tr>

</tbody>
</table>
</div>
</div>
<div class="footer">
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:14:21 GMT+0200 (CEST)</div>
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:57:46 GMT+0200 (CEST)</div>
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
96 changes: 45 additions & 51 deletions coverage/PhantomJS 1.9.8 (Mac OS X 0.0.0)/lcov-report/src/ng-reading-indicator.js.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<div class="header low">
<h1>Code coverage report for <span class="entity">src/ng-reading-indicator.js</span></h1>
<h2>
Statements: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">16.09% <small>(14 / 87)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">43.75% <small>(7 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">32.22% <small>(29 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Statements: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Branches: <span class="metric">18.56% <small>(18 / 97)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Functions: <span class="metric">56.25% <small>(9 / 16)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Lines: <span class="metric">43.33% <small>(39 / 90)</small></span> &nbsp;&nbsp;&nbsp;&nbsp;
Ignored: <span class="metric"><span class="ignore-none">none</span></span> &nbsp;&nbsp;&nbsp;&nbsp;
</h2>
<div class="path"><a href="../index.html">All files</a> &#187; <a href="index.html">src/</a> &#187; ng-reading-indicator.js</div>
Expand Down Expand Up @@ -222,9 +222,7 @@ <h2>
195
196
197
198
199
200</td><td class="line-coverage"><span class="cline-any cline-yes">1</span>
198</td><td class="line-coverage"><span class="cline-any cline-yes">1</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
Expand Down Expand Up @@ -297,6 +295,8 @@ <h2>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
Expand All @@ -317,31 +317,30 @@ <h2>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-yes">3</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-yes">3</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
Expand All @@ -362,8 +361,6 @@ <h2>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
Expand All @@ -379,7 +376,6 @@ <h2>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1</span>
<span class="cline-any cline-no">&nbsp;</span>
<span class="cline-any cline-no">&nbsp;</span>
Expand Down Expand Up @@ -496,6 +492,8 @@ <h2>
&nbsp;
<span class="missing-if-branch" title="if path not taken" >I</span>if (!options.expand &amp;&amp; <span class="branch-1 cbranch-no" title="branch not covered" >options.type !== 'small')</span> {
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-expanded');</span>
} else <span class="missing-if-branch" title="if path not taken" >I</span>if (!options.expand &amp;&amp; <span class="branch-1 cbranch-no" title="branch not covered" >options.type !== 'big')</span> {
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
}
&nbsp;
elem = (!scope.elementClass || <span class="branch-1 cbranch-no" title="branch not covered" >scope.elementClass === '')</span> ? $window : <span class="branch-1 cbranch-no" title="branch not covered" >scope.elementClass;</span>
Expand All @@ -515,32 +513,31 @@ <h2>
}
&nbsp;
<span class="cstat-no" title="statement not covered" > scope.headline = (headline) ? headline : null;</span>
&nbsp;
<span class="cstat-no" title="statement not covered" > updateSize();</span>
&nbsp;
<span class="cstat-no" title="statement not covered" > angular.element($window).on('scroll', updateProgress);</span>
<span class="cstat-no" title="statement not covered" > angular.element($window).on('resize', updateSize);</span>
});
}
&nbsp;
updateSize();
&nbsp;
angular.element($window).on('scroll', updateProgress);
angular.element($window).on('resize', updateSize);
}
&nbsp;
<span class="fstat-no" title="function not covered" > function findEdges(elem) {</span>
<span class="cstat-no" title="statement not covered" > var bodyRect = document.body.getBoundingClientRect(),</span>
function findEdges(elem) {
var bodyRect = document.body.getBoundingClientRect(),
elemRect = elem.getBoundingClientRect();
&nbsp;
<span class="cstat-no" title="statement not covered" > return {</span>
return {
top: (elemRect.top - bodyRect.top),
bottom: (elem.scrollHeight - window.innerHeight &gt; 0 ) ? elem.scrollHeight - window.innerHeight : elem.scrollHeight,
bottom: (elem.scrollHeight - window.innerHeight &gt; 0 ) ? <span class="branch-0 cbranch-no" title="branch not covered" >elem.scrollHeight - window.innerHeight </span>: elem.scrollHeight,
height: elemRect.height
};
}
&nbsp;
<span class="fstat-no" title="function not covered" > function updateSize() {</span>
<span class="cstat-no" title="statement not covered" > bottom = findEdges(article[0]).bottom;</span>
<span class="cstat-no" title="statement not covered" > top = findEdges(article[0]).top;</span>
<span class="cstat-no" title="statement not covered" > height = findEdges(article[0]).height;</span>
<span class="cstat-no" title="statement not covered" > expandOffset = (expandOnHeadline) ? findEdges(article.find('h1')[0]) : {top: 50};</span>
<span class="cstat-no" title="statement not covered" > updateProgress();</span>
function updateSize() {
bottom = findEdges(article[0]).bottom;
top = findEdges(article[0]).top;
height = findEdges(article[0]).height;
expandOffset = (expandOnHeadline) ? <span class="branch-0 cbranch-no" title="branch not covered" >findEdges(article.find('h1')[0]) </span>: {top: 50};
}
&nbsp;
<span class="fstat-no" title="function not covered" > function updateProgress() {</span>
Expand All @@ -561,21 +558,18 @@ <h2>
}
&nbsp;
<span class="cstat-no" title="statement not covered" > progressBar.style.width = progress + '%';</span>
&nbsp;
<span class="cstat-no" title="statement not covered" > if (options.expand) {</span>
<span class="cstat-no" title="statement not covered" > if (scrollPos &gt; top &amp;&amp; scrollPos &lt; (top + expandOffset.top + options.topOffset)) {</span>
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '5px';</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
} else <span class="cstat-no" title="statement not covered" >if (scrollPos &gt;= (top + expandOffset.top + options.topOffset)) {</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-expanded');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '';</span>
}else {
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '0';</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
}
<span class="cstat-no" title="statement not covered" > if ((!options.expand &amp;&amp; options.type === 'small' &amp;&amp; scrollPos &gt;= (top + expandOffset.top + options.topOffset)) || (options.expand &amp;&amp; scrollPos &gt; top &amp;&amp; scrollPos &lt; (top + expandOffset.top + options.topOffset))) {</span>
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '5px';</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
} else <span class="cstat-no" title="statement not covered" >if (((!options.expand &amp;&amp; options.type === 'big') || options.expand) &amp;&amp; scrollPos &gt;= (top + expandOffset.top + options.topOffset)) {</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-expanded');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '';</span>
} else {
<span class="cstat-no" title="statement not covered" > angular.element(element)[0].style.height = '0';</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).addClass('ng-reading-indicator-shrink');</span>
<span class="cstat-no" title="statement not covered" > angular.element(element).removeClass('ng-reading-indicator-expanded');</span>
}
}
&nbsp;
Expand Down Expand Up @@ -627,7 +621,7 @@ <h2>

</div>
<div class="footer">
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:14:21 GMT+0200 (CEST)</div>
<div class="meta">Generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Tue Jul 14 2015 10:57:46 GMT+0200 (CEST)</div>
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
Loading

0 comments on commit 4ec1f8c

Please sign in to comment.